Revert basemodelica.jl import #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnHeuermann
added a commit
to AnHeuermann/OpenModelicaLibraryTesting
that referenced
this pull request
Sep 19, 2025
This reverts commit a0cb54d.
AnHeuermann
added a commit
that referenced
this pull request
Sep 19, 2025
* Revert "Revert basemodelica.jl import (#225)" - Make module juliacall optional - Use shutil.which
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The nightly tests are still broken, because our installLibraries.mos failed at the same time I added a new test.
Reverting the BaseModelica.jl test for now, so we get at least one clean nightly test.