Draft
Conversation
Signed-off-by: Nick Vissers <[email protected]>
nickvissers
force-pushed
the
go-fiovb-library
branch
from
d6cda1c to
014aa4e
Compare
Contributor
Author
|
bravl
reviewed
Jan 15, 2024
Member
bravl
left a comment
bravl
left a comment
There was a problem hiding this comment.
Might be interesting to also add dependabot. This way it's easy to keep dependancies up to date.
cmd/fiovb/main.go
Outdated
| } | ||
| } | ||
|
|
||
| func read(name string) error { |
Member
There was a problem hiding this comment.
Nitpick: could you move this above main. So that the main is always the bottom fuction.
This makes it easier for new developers to know where to start.
fiovb/fiovb_api.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| clockSeqAndNode = [8]byte{0x80, 0x02, 0x7b, 0x20, 0xf1, 0xc9, 0xc9, 0xb1} |
Member
There was a problem hiding this comment.
Maybe a small comment about this 8 byte magic value
Signed-off-by: Nick Vissers <[email protected]>
Signed-off-by: Nick Vissers <[email protected]>
Signed-off-by: Nick Vissers <[email protected]>
nickvissers
force-pushed
the
go-fiovb-library
branch
from
014aa4e to
81af4a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.