Fix off-by-one error with size of hash space #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the previous code used truncated floats to calculate, and the the numbers are bigger than 2 ^ 53, the off-by-one error never mattered due to approximation: i.e. ```erlang 1> trunc(math:pow(2, 160) - 1) == trunc(math:pow(2,160)). true ``` But relying on this is confusing.
WarpEngineer
approved these changes
Feb 25, 2025
hmmr
pushed a commit
to TI-Tokyo/riak_core
that referenced
this pull request
Mar 15, 2025
…atetypes Correct types on get_modstate/1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the previous code used truncated floats to calculate, and the the numbers are bigger than 2 ^ 53, the off-by-one error never mattered due to approximation:
i.e.
But relying on this is confusing.