Nhse main i1 dirtynifflag #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.erlang.org/doc/man/erl_nif.html documentation indicates the threshold for being a dirty NIF should be about 1ms. Generally compress/decompress is much quicker than this. Testing indicates a significant overhead from using this flag when compress/decompress is in fact very fast.
Using a dirty_nif for smaller objects has a performance penalty so: - by default don't use the dirty nif if compressing < 250KB or uncompressing < 50KB - allow application to override and specifically request either dirty or quick method.
stephenwood24-nhs
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only add the DIRTY_NIF flag when attempting to compress/decompress a relatively large binary - threshold set to 250KB (compression), 50KB (decompression). For small (and one would expect quick) compress/decompress options the overhead of making the call a DIRTY_NIF erodes the performance advantages of using zstd.