Skip to content

Add global model reference to ground truth #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

pmai
Copy link
Contributor

@pmai pmai commented Aug 18, 2020

This PR represents a PR from the SETLevel4To5 project, adding an optional model_reference to the top-level ground truth, to allow the specification of a 3D model representing the environment: This model covers the static parts of the environment that are not provided as individual models referenced from ground truth objects like moving or stationary objects. It is implementation-specific which exact parts this world model contains, e.g. whether it contains street geometries, or whether those are derived automatically from a map reference, if one is provided.

Signed-off-by: Pierre R. Mai [email protected]

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@pmai pmai self-assigned this Aug 18, 2020
@pmai pmai added this to the V3.3.0 milestone Oct 28, 2020
@pmai pmai marked this pull request as ready for review October 28, 2020 11:21
@kmeids kmeids added ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. FeatureRequest Proposals which enhance the interface or add additional features. SensorModeling The Group in the ASAM development project working on sensor modeling topics. labels Oct 28, 2020
@kmeids
Copy link

kmeids commented Nov 25, 2020

Output from CCB meeting - 25.11.2020

Actions:
@paagkame to review the documentation under "Files changed".

@kmeids kmeids added Documentation Everything which impacts the quality of the documentation and guidelines. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Nov 25, 2020
@paagkame
Copy link
Contributor

paagkame commented Dec 4, 2020

documentation review is done. Please have a look at the changes.

@kmeids kmeids added ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. and removed Documentation Everything which impacts the quality of the documentation and guidelines. labels Dec 5, 2020
@kmeids
Copy link

kmeids commented Dec 9, 2020

Output from CCB meeting - 09.12.2020
Actions:

  1. Pull request to be merged by @pmai

@kmeids kmeids added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Dec 9, 2020
@pmai pmai force-pushed the feature/global-model-reference branch from 259d92a to d1cfb20 Compare December 9, 2020 11:56
@clemenshabedank clemenshabedank self-requested a review December 9, 2020 12:08
pmai and others added 2 commits December 9, 2020 13:17
@pmai pmai force-pushed the feature/global-model-reference branch from d1cfb20 to 711250d Compare December 9, 2020 12:19
@pmai pmai merged commit da4963c into master Dec 9, 2020
@pmai pmai deleted the feature/global-model-reference branch December 9, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest Proposals which enhance the interface or add additional features. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. SensorModeling The Group in the ASAM development project working on sensor modeling topics. WP7 - Visualization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants