Skip to content

Migration of build pipeline to GitHub actions #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 12, 2021
Merged

Migration of build pipeline to GitHub actions #514

merged 8 commits into from
May 12, 2021

Conversation

stefancyliax
Copy link
Contributor

Migration of build pipeline to Github Actions from TravisCI

  • Pipeline was migrated to Github Actions
  • Protobuf updated to current version

@stefancyliax stefancyliax requested a review from pmai April 26, 2021 07:47
@stefancyliax
Copy link
Contributor Author

@pmai Can you review please?
I forked of you and added

  • deploy to gh-pages
  • update to current proto version

pmai
pmai requested changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think those links will work for the badges, it must be keyed off the workflow name.

Other than the screwed up DCO this looks good to me.

@stefancyliax stefancyliax added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Apr 28, 2021
@kmeids
Copy link

kmeids commented Apr 28, 2021

Output CCB 28.04.2021:

  1. To be done after the 3.3.1 release.
  2. @pmai please rebase for DCO
  3. @stefancyliax re-do the DCO

@kmeids kmeids removed the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Apr 28, 2021
@stefancyliax
Copy link
Contributor Author

  1. @stefancyliax re-do the DCO

We discusses that I will merge this after the DCO is sorted out.

@stefancyliax stefancyliax added this to the V3.4.0 milestone May 1, 2021
@stefancyliax
Copy link
Contributor Author

@pmai Could you please rebase to fix DCO?

@stefancyliax stefancyliax added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label May 12, 2021
@stefancyliax stefancyliax self-assigned this May 12, 2021
@kmeids
Copy link

kmeids commented May 12, 2021

Output CCB 12.05.2021:

  1. @pmai to do the DCO and merge.

@kmeids kmeids added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels May 12, 2021
pmai and others added 8 commits May 12, 2021 12:11
@pmai
Initial GitHub Actions CPP ProtoBuf Build
ae75a40 
Signed-off-by: Pierre R. Mai <[email protected]>
@pmai
Add Python ProtoBuf build
72a2ba1 
Signed-off-by: Pierre R. Mai <[email protected]>
@pmai
Add documentation generation
ff2ef96 
Signed-off-by: Pierre R. Mai <[email protected]>
@pmai
Add Proto3 Test Builds
33c4e2b 
Signed-off-by: Pierre R. Mai <[email protected]>
@pmai
Adjust version number for Doxygen documentation
1cb802f 
Signed-off-by: Pierre R. Mai <[email protected]>
@pmai
Update Build status badge to GitHub Actions CI
707d4f8 
Signed-off-by: Pierre R. Mai <[email protected]>
@pmai
added deploy to gh-pages and update to current protobuf version
62365c3 
Signed-off-by: Stefan Cyliax <[email protected]>
@pmai
preparation of badge address to target repo
1489f9a 
Signed-off-by: Stefan Cyliax <[email protected]>
@pmai pmai closed this May 12, 2021
@pmai pmai reopened this May 12, 2021
@pmai pmai merged commit e37a8c5 into OpenSimulationInterface:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmai pmai pmai approved these changes

Assignees

@stefancyliax stefancyliax

Labels
ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Milestone
V3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stefancyliax @kmeids @pmai