Set typography #30
Set typography #30
Conversation
| <script type="text/javascript" src="/assets/statics/polyfills/jsonp.js"></script> |
There was a problem hiding this comment.
hmmm.. I don't really see the change in this line... Is it a deleted 'return'?
There was a problem hiding this comment.
Is probably just the way Github shows how happy he is to have a new empty line at the end of the file
| @@ -4,7 +4,14 @@ | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
|
|
|||
| <title>{% if page.title %}{{ page.title }}{% else %}{{ site.title }}{% endif %}{% if page.tagline %} || {{page.tagline}}{%endif%} || OpenTechSchool.org</title> | |||
| <meta name="description" content="{{ site.description }}"> | |||
| <meta name="description" content="{{ site.description }}" /> | |||
| <meta name="author" content="OpenTechSchool"> | |||
There was a problem hiding this comment.
Is this correct that this line doesn't have the tag ending finalized with ' / ' while all the others do??
There was a problem hiding this comment.
Yeah would be nicer if it has too. / is semantically correct even if most of the modern browsers will fix it for us.
I would say is not a blocker but I will add it in the future for sure.
There was a problem hiding this comment.
With the document type we are using (<!DOCTYPE html>) the self-closing slash is not needed.
Add Montserrat font, chose and add Esteban font for paragraph.
Set document, title and text style.
Adjust hero, logo and menu based on new font-base style.
Refering Issue: #23