feat: Update Chain Reorg Detection and Handling #187
+895
−420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore emitting live
This reverts commit 9a63182.
This reverts commit 8169ed7.
This reverts commit 13bd108.
0xNeshi
commented
Nov 20, 2025
| use tracing::{debug, error, info, warn}; | ||
|
|
||
| #[allow(clippy::too_many_arguments)] | ||
| pub(crate) async fn stream_live_blocks<N: Network>( |
Collaborator
Author
There was a problem hiding this comment.
Given the amount of changes to the block_range_scanner.rs, it was becoming hard to understand the implication of those changes.
I figured it would be a good time to extract these common functions and to refactor handle_sync for two reasons:
- Easier to review -
stream_live_blocksandstream_historical_blocksbehave completely differently from before, and can be regarded as completely new functions. Moving them to common.rs makes the reviewer look at these functions for what they are - new functions. - Show what the future
BlockRangeScannerrefactor could look like (see sync_handler.rs) - each mode would be its own "strategy" type.
0xNeshi
commented
Nov 21, 2025
Comment on lines
+381
to
+388
| let sync_handler = SyncHandler::new( | ||
| self.provider.clone(), | ||
| self.max_block_range, | ||
| start_id, | ||
| block_confirmations, | ||
| sender, | ||
| ); | ||
| sync_handler.run().await |
Collaborator
Author
There was a problem hiding this comment.
this is a strategy-like pattern that we could use for mode handling. The logic is all contained within the strategy type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #56
Resolves #76
Resolves #5
Resolves #155