Remove scanner error enum #200
Merged
+323
−233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xNeshi
reviewed
Nov 20, 2025
LeoPatOZ
added
the
type: refactor
0xNeshi
reviewed
Nov 21, 2025
Collaborator
0xNeshi
left a comment
0xNeshi
left a comment
There was a problem hiding this comment.
looking better, close to merging
| } | ||
|
|
||
| impl<T: Clone, E: Error + Clone> PartialEq<Notification> for ScannerMessage<T, E> { | ||
| impl<T: Clone> PartialEq<Notification> for ScannerMessage<T> { |
Collaborator
There was a problem hiding this comment.
Try to implement impl<T: Clone> PartialEq<ScannerError> for Result<ScannerResult<T>> {, should make additional assert_next! variants redundant
Collaborator
Author
There was a problem hiding this comment.
okay done! good catch.
Man i hate working with macros sometimes, the LSP doesnt help much
0xNeshi
reviewed
Nov 21, 2025
0xNeshi
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #181