fix(components): keep AddressListField entry toggle flush to the input - #198
Merged
Conversation
✅ Deploy Preview for openzeppelin-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The single/bulk entry-mode toggle is now an attached tab pinned flush to the input's bottom-right corner (inset from the rounded corner). It no longer shifts when the resolution announcer or bulk preview text appears, and no longer overlaps the action button when the field is empty. - Add `announcerEndSlot` to `AddressField` and `helperEndSlot` to `TextAreaField` to pin trailing content beside the announcer/helper row - Render the toggle and announcer/helper in one in-flow row that reserves height, cancelling the parent gap so the toggle sits flush - Lift the input/textarea above the toggle (z-10) so the focus ring is not covered by the overlapping tab - Cover the layout in AddressField/AddressListField/TextAreaField tests Co-authored-by: Cursor <cursoragent@cursor.com>
pasevin
force-pushed
the
fix/addresslistfield-toggle-flush
branch
from
July 20, 2026 20:32
c113149 to
9491a7b
Compare
pasevin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the visual glitches in
AddressListField's entry-mode toggle across single and bulk modes:z-10) so the focus ring is not covered by the overlapping tab.API
AddressFieldgainsannouncerEndSlot?: React.ReactNode— trailing content pinned beside the resolution announcer row.TextAreaFieldgainshelperEndSlot?: React.ReactNode— trailing content pinned beside the helper-text row.Both are additive and backward-compatible: when omitted, the components render exactly as before (standalone
AddressFieldannouncer behavior is unchanged when no resolver is mounted).Test plan
pnpm --filter @openzeppelin/ui-components lint:fixpnpm --filter @openzeppelin/ui-components test— 318 passing (added layout coverage inAddressField.announcerEndSlot.test.tsxandAddressListField.test.tsx)pnpm --filter @openzeppelin/ui-components buildexamples/basic-react-app→ Forms → AddressListField):vitalik.eth): toggle flush, announcer gapped, no shiftChangeset
patchon@openzeppelin/ui-components.