chore(release): version packages - #220
Merged
Merged
Conversation
✅ Deploy Preview for openzeppelin-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@openzeppelin/ui-dev-cli@1.3.0
Minor Changes
#219
1c63230Thanks @pasevin! - The generated.pnpmfile.cjsnow also strips@metamask/sdkfrom@wagmi/connectors,alongside the existing WalletConnect and Trezor strips.
@metamask/sdkis not open source. It ships a proprietary licence — "Copyright ConsenSysSoftware Inc. 2022. All rights reserved" — granting only a non-exclusive, non-transferable
licence for Non-Commercial Use, whose clause 2 requires any Resulting Program to carry that
same restriction forward. The OpenZeppelin adapters are AGPL-3.0, which forbids conveying the
work under added restrictions, so the two cannot both be satisfied.
The conflict is structural rather than a threshold question — it does not depend on any monthly
active user count — and there is no clean version to pin: no published version of
@metamask/sdkdeclares alicensefield at all. The same 2715-byte licence file ships in@metamask/sdk,@metamask/sdk-communication-layerand@metamask/sdk-install-modal-web.@wagmi/connectorsdeclares@metamask/sdkas a hard dependency, not an optional peer, soit installed whether or not a
metaMask()connector was registered. Dropping the connectoralone is not sufficient, hence the hook.
The strip targets that one package name exactly, not the
@metamask/*scope. Most of thatscope is MIT or ISC (
utils,providers,json-rpc-engine,rpc-errors,superstruct,sdk-analytics, …) and is legitimately required transitively; a scope-wide strip would breakfar more than it fixes.
Consumer repositories must regenerate their hook (
oz-ui-dev init, or by copying thegenerated file) to pick this up, and will also need a bundler alias pointing
@metamask/sdkata local stub —
@wagmi/connectorsre-exports an unreachablemetaMaskmodule containingawait import('@metamask/sdk'), and Rollup resolves dynamic imports at build time, so withoutthe alias the production build fails with "Rollup failed to resolve import".