Add Social Profile #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liveHarshit, @kushthedude, @mariobehling Can any mentor please review this. I have been waiting for 2 days. |
|
@kushthedude Can you please merge my PR? |
|
Actually I dont have merge rights for this repository.
@mariobehling @hpdang Please check and merge it.
…On Sun, 12 Jan, 2020, 07:02 Dat, ***@***.***> wrote:
@kushthedude <https://github.com/kushthedude> Can you please merge my PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#64?email_source=notifications&email_token=AKQMTLVKYEAZUG7HRRTBINTQ5JXJJA5CNFSM4KE23IK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWPIGQ#issuecomment-573371418>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKQMTLS5R7OJ3PHKAVKC2T3Q5JXJJANCNFSM4KE23IKQ>
.
|
|
@kushthedude ok, thanks. You review so fast! |
cweitat
suggested changes
Jan 12, 2020
| @@ -551,7 +555,8 @@ <h1>Speakers</h1> | |||
| <a href="https://github.com/rbscholtus"><i class="icon fa fa-github"></i></a> | |||
| <a href="https://twitter.com/rbscholtus"><i class="icon fa fa-twitter"></i></a> | |||
| <a href="https://www.facebook.com/barend.scholtus"><i class="icon fa fa-facebook"></i></a> | |||
| </div> | |||
| <a href="https://www.instagram.com/barend.scholtus/"><i class="icon fa fa-instagram"></i></a> | |||
| @@ -442,10 +442,13 @@ <h1>Speakers</h1> | |||
| <div class="hover-state text-center preserve3d"> | |||
| <div class="social-links vertical-align"> | |||
| <a href="https://github.com/mariobehling/"><i class="icon fa fa-github"></i></a> | |||
| <a href="https://www.flickr.com/photos/rportrr/"><i class="icon fa fa-flickr"></i></a> | |||
| <a href="https://twitter.com/mariobehling" target="default"><i class="icon social_twitter"></i></a> | ||
| <a href="https://www.facebook.com/mariobehling" target="default"><i class="icon social_facebook"></i></a> | ||
| <a href="https://www.linkedin.com/in/mariobehling" target="_self"><i class="icon social_linkedin"></i></a> | ||
| </div> | ||
| <a href="https://www.youtube.com/user/mariobehling" target="default"><i class="icon social_youtube"></i></a> | ||
| <a href="https://blog.ffii.org/author/mariobehling/" target="_self"><i class="icon fa fa-external-link"></i></a> |
There was a problem hiding this comment.
how is link that is updated at 2015 useful?
| <a href="https://twitter.com/mariobehling" target="default"><i class="icon social_twitter"></i></a> | ||
| <a href="https://www.facebook.com/mariobehling" target="default"><i class="icon social_facebook"></i></a> | ||
| <a href="https://www.linkedin.com/in/mariobehling" target="_self"><i class="icon social_linkedin"></i></a> | ||
| </div> | ||
| <a href="https://www.youtube.com/user/mariobehling" target="default"><i class="icon social_youtube"></i></a> |
There was a problem hiding this comment.
how is the channel useful in telling the profile of person??
Comment on lines
+745
to
+747
| <div class="social-links vertical-align"> | ||
| <a href="https://www.linkedin.com/in/tantrieuf31/"><i class="icon fa fa-linkedin"></i></a> | ||
| </div> |
Comment on lines
+761
to
+763
| <div class="social-links vertical-align"> | ||
| <a href="https://www.linkedin.com/in/trang1/"<i class="icon fa fa-linkedin"></i></a> | ||
| </div> |
| @@ -767,7 +778,8 @@ <h1>Speakers</h1> | |||
| <a href="https://twitter.com/felixbecquart"><i class="icon social_twitter"></i></a> | |||
| <a href="https://github.com/FelixBecquart1990"><i class="icon fa fa-github"></i></a> | |||
| <a href="https://www.facebook.com/felix.becquart"><i class="icon social_facebook"></i></a> | |||
| </div> | |||
| <a href="https://www.linkedin.com/in/f%C3%A9lix-becquart-8a5a46a6/"><i class="icon social_linkedin"></i></a> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work for this issue: #63
I have added links to various social profile of some of the speakers in the Fossasia OpenTechSummit Vietnam.
The deployment link: https://hoangdatngo.github.io/vn.opentechsummit.asia/
@mariobehling, @kushthedude, @hpdang Can any mentor please review my PR?