Skip to content

Code refactor of sampling mode. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saying121 merged 1 commit into from
Aug 22, 2025
Merged

Code refactor of sampling mode. #36

saying121 merged 1 commit into from
Aug 22, 2025

Conversation

@BrytonLee
Copy link
Member

@BrytonLee BrytonLee commented Aug 22, 2025

  1. renamed extra_config to sampler_config, sample_record_fields to sample_fields
  2. renamed config::new to config::builder
  3. renamed extra_record to side_band_record
  4. renamed SampleRecordFields.v to SampleRecordFields.read
  5. removed sampling/record/body directory and simplified each record type definition
  6. Add missing AuxOutputHwIdRecord
  7. Improved SampleId implementation.
  8. Added a new BasicFlags and derives for better representing record.misc field.
  9. Added memory barriers between ring read/write operations.

@saying121 saying121 merged commit f6be765 into main Aug 22, 2025
0 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@saying121 saying121 saying121 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@saying121 saying121

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrytonLee @saying121