Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grammar and add parsing support for urlQueryParam #3863

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ashishajr
Copy link
Contributor

Description

Add grammar for urlQueryParam
Add parsing support for urlQueryParam
Add formatter support for urlQueryParam

Related Issue
#2199

@ashishajr
Copy link
Contributor Author

Hey @jcamiel, had a quick question, I noticed that in hurl.grammar for the toDate filter, the grammar is defined as to-date-filter: "toDate"

But shouldn't be to-date-filter: "toDate" sp quoted-string (with quoted-string) as toDate can take the format as input? Or am I missing something?

@jcamiel
Copy link
Collaborator

jcamiel commented Mar 17, 2025

No @ashishajr you're exactly right, the grammar is not correct, it should be to-date-filter: "toDate" sp quoted-string like you tell. If you want, you can make another PR to fix it!

@ashishajr ashishajr force-pushed the url-query-param-parsing-grammar branch from da127da to d283b0c Compare March 17, 2025 17:03
@ashishajr
Copy link
Contributor Author

No @ashishajr you're exactly right, the grammar is not correct, it should be to-date-filter: "toDate" sp quoted-string like you tell. If you want, you can make another PR to fix it!

Sure, let me raise another PR for that

@ashishajr
Copy link
Contributor Author

Hey @jcamiel, looks like the tests_ssl/certs/server/cert.pem has expired and that's why the tests are failing

$ server % openssl x509 -enddate -noout -in cert.pem           
notAfter=Mar 15 10:48:00 2025 GMT

Thought I messed something up 😮‍💨 😅

@jcamiel
Copy link
Collaborator

jcamiel commented Mar 17, 2025

Yes there is a minor 6.1.1 release branch with the fixes fir these tests, it should land at the end of this week on master. You can rebase your branch in this branch, that should fix the tests

@ashishajr ashishajr force-pushed the url-query-param-parsing-grammar branch from d283b0c to 0bc2a75 Compare March 18, 2025 09:18
@ashishajr
Copy link
Contributor Author

@jcamiel let me know if this looks good, I messed up the tree with my other PR so if this looks good I'll do the same there. I closed it for meanwhile so I don't end up spamming the workflow bot

@jcamiel
Copy link
Collaborator

jcamiel commented Mar 18, 2025

Thanks
We're working on the 6.1.1 patch version, once this version will be me merged, you'll able to rebase this PR and I will review it.

@ashishajr
Copy link
Contributor Author

Thanks We're working on the 6.1.1 patch version, once this version will be me merged, you'll able to rebase this PR and I will review it.

Great, thanks a lot, I'll rebase the toDate grammar PR too :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants