Skip to content

Commit

Permalink
chore(🤖): update CheckRadioComponentTokens
Browse files Browse the repository at this point in the history
Tokens library v0.4.1

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
  • Loading branch information
pylapp committed Jan 30, 2025
1 parent 110a628 commit 0c84f73
Show file tree
Hide file tree
Showing 8 changed files with 25 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import OUDSTokensSemantic
///
/// // Then override the radio / check component tokens you want.
///
/// override var checkRadioSize: SizeSemanticToken { sizes.sizeIconWithLabelLargeSizeXl }
/// override var checkRadioSizeSelector: SizeSemanticToken { sizes.sizeIconWithLabelLargeSizeXl }
///
/// override var checkRadioSizeMaxHeightAssetsContainer: DimensionRawToken { DimensionRawTokens.dimension1000 }
///
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,10 @@ import OUDSTokensComponent
import OUDSTokensRaw
import OUDSTokensSemantic

// ଘ( ・ω・)_/゚・:*:・。☆
// [File to generate with the tokenator]
// Values are not the expected ones, manual fixes have been added
// Create an issue for update https://github.com/Orange-OpenSource/ouds-ios/issues/new?template=token_update.yml

extension OrangeThemeCheckRadioComponentTokensProvider: CheckRadioComponentTokens {
@objc open var checkRadioSize: SizeSemanticToken { sizes.sizeIconWithLabelLargeSizeSm }
@objc open var checkRadioSizeMinHeightSelectorOnly: DimensionRawToken { DimensionRawTokens.dimension600 }
@objc open var checkRadioSizeMinWidthSelectorOnly: DimensionRawToken { DimensionRawTokens.dimension600 }
@objc open var checkRadioSizeMaxHeightSelectorOnly: DimensionRawToken { DimensionRawTokens.dimension600 }
@objc open var checkRadioSizeMaxHeightAssetsContainer: DimensionRawToken { DimensionRawTokens.dimension1200 }
@objc open var checkRadioSizeMaxHeightAssetsContainer: SizeSemanticToken { DimensionRawTokens.dimension1200 }
@objc open var checkRadioSizeMaxHeightSelectorOnly: SizeSemanticToken { DimensionRawTokens.dimension600 }
@objc open var checkRadioSizeMinHeightSelectorOnly: SizeSemanticToken { DimensionRawTokens.dimension600 }
@objc open var checkRadioSizeMinWidthSelectorOnly: SizeSemanticToken { DimensionRawTokens.dimension600 }
@objc open var checkRadioSizeSelector: SizeSemanticToken { sizes.sizeIconWithLabelLargeSizeSm }
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ final class MockThemeCheckRadioComponentTokenProvider: OrangeThemeCheckRadioComp

// MARK: - Badge component tokens

override public var checkRadioSize: SizeSemanticToken { Self.mockThemeCheckRadioSize }
override public var checkRadioSizeSelector: SizeSemanticToken { Self.mockThemeCheckRadioSize }
override public var checkRadioSizeMinHeightSelectorOnly: DimensionRawToken { Self.mockThemeCheckRadioDimension }
override public var checkRadioSizeMinWidthSelectorOnly: DimensionRawToken { Self.mockThemeCheckRadioDimension }
override public var checkRadioSizeMaxHeightSelectorOnly: DimensionRawToken { Self.mockThemeCheckRadioDimension }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,30 +32,30 @@ final class TestThemeOverrideOfCheckRadioComponentTokens: XCTestCase {
// MARK: - Sizes

func testInheritedThemeCanOverrideCheckRadioComponentTokenSize() throws {
XCTAssertNotEqual(inheritedTheme.checkRadio.checkRadioSize, abstractTheme.checkRadio.checkRadioSize)
XCTAssertTrue(inheritedTheme.checkRadio.checkRadioSize == MockThemeCheckRadioComponentTokenProvider.mockThemeCheckRadioSize)
XCTAssertNotEqual(inheritedTheme.checkRadio.checkRadioSizeSelector, abstractTheme.checkRadio.checkRadioSizeSelector)
XCTAssertTrue(inheritedTheme.checkRadio.checkRadioSizeSelector == MockThemeCheckRadioComponentTokenProvider.mockThemecheckRadioSize)

Check failure on line 36 in OUDS/Core/Themes/Orange/Tests/Values/ComponentTokens/TestThemeOverrideOCheckRadioComponentTokens.swift

View workflow job for this annotation

GitHub Actions / unit-test

type 'MockThemeCheckRadioComponentTokenProvider' has no member 'mockThemecheckRadioSize'
}

// MARK: - Dimensions

func testInheritedThemeCanOverrideCheckRadioComponentTokenSizeMinHeightSelectorOnly() throws {
XCTAssertNotEqual(inheritedTheme.checkRadio.checkRadioSizeMinHeightSelectorOnly, abstractTheme.checkRadio.checkRadioSizeMinHeightSelectorOnly)
XCTAssertTrue(inheritedTheme.checkRadio.checkRadioSizeMinHeightSelectorOnly == MockThemeCheckRadioComponentTokenProvider.mockThemeCheckRadioDimension)
XCTAssertNotEqual(inheritedTheme.checkRadio.checkRadioSizeSelectorMinHeightSelectorOnly, abstractTheme.checkRadio.checkRadioSizeSelectorMinHeightSelectorOnly)

Check failure on line 42 in OUDS/Core/Themes/Orange/Tests/Values/ComponentTokens/TestThemeOverrideOCheckRadioComponentTokens.swift

View workflow job for this annotation

GitHub Actions / unit-test

value of type 'any AllCheckRadioComponentTokensProvider' has no member 'checkRadioSizeSelectorMinHeightSelectorOnly'

Check failure on line 42 in OUDS/Core/Themes/Orange/Tests/Values/ComponentTokens/TestThemeOverrideOCheckRadioComponentTokens.swift

View workflow job for this annotation

GitHub Actions / unit-test

value of type 'any AllCheckRadioComponentTokensProvider' has no member 'checkRadioSizeSelectorMinHeightSelectorOnly'
XCTAssertTrue(inheritedTheme.checkRadio.checkRadioSizeSelectorMinHeightSelectorOnly == MockThemeCheckRadioComponentTokenProvider.mockThemeCheckRadioDimension)

Check failure on line 43 in OUDS/Core/Themes/Orange/Tests/Values/ComponentTokens/TestThemeOverrideOCheckRadioComponentTokens.swift

View workflow job for this annotation

GitHub Actions / unit-test

value of type 'any AllCheckRadioComponentTokensProvider' has no member 'checkRadioSizeSelectorMinHeightSelectorOnly'
}

func testInheritedThemeCanOverrideCheckRadioComponentTokenSizeMinWidthSelectorOnly() throws {
XCTAssertNotEqual(inheritedTheme.checkRadio.checkRadioSizeMinWidthSelectorOnly, abstractTheme.checkRadio.checkRadioSizeMinWidthSelectorOnly)
XCTAssertTrue(inheritedTheme.checkRadio.checkRadioSizeMinWidthSelectorOnly == MockThemeCheckRadioComponentTokenProvider.mockThemeCheckRadioDimension)
XCTAssertNotEqual(inheritedTheme.checkRadio.checkRadioSizeSelectorMinWidthSelectorOnly, abstractTheme.checkRadio.checkRadioSizeSelectorMinWidthSelectorOnly)

Check failure on line 47 in OUDS/Core/Themes/Orange/Tests/Values/ComponentTokens/TestThemeOverrideOCheckRadioComponentTokens.swift

View workflow job for this annotation

GitHub Actions / unit-test

value of type 'any AllCheckRadioComponentTokensProvider' has no member 'checkRadioSizeSelectorMinWidthSelectorOnly'

Check failure on line 47 in OUDS/Core/Themes/Orange/Tests/Values/ComponentTokens/TestThemeOverrideOCheckRadioComponentTokens.swift

View workflow job for this annotation

GitHub Actions / unit-test

value of type 'any AllCheckRadioComponentTokensProvider' has no member 'checkRadioSizeSelectorMinWidthSelectorOnly'
XCTAssertTrue(inheritedTheme.checkRadio.checkRadioSizeSelectorMinWidthSelectorOnly == MockThemeCheckRadioComponentTokenProvider.mockThemeCheckRadioDimension)

Check failure on line 48 in OUDS/Core/Themes/Orange/Tests/Values/ComponentTokens/TestThemeOverrideOCheckRadioComponentTokens.swift

View workflow job for this annotation

GitHub Actions / unit-test

value of type 'any AllCheckRadioComponentTokensProvider' has no member 'checkRadioSizeSelectorMinWidthSelectorOnly'
}

func testInheritedThemeCanOverrideCheckRadioComponentTokenSizeMaxHeightSelectorOnly() throws {
XCTAssertNotEqual(inheritedTheme.checkRadio.checkRadioSizeMaxHeightSelectorOnly, abstractTheme.checkRadio.checkRadioSizeMaxHeightSelectorOnly)
XCTAssertTrue(inheritedTheme.checkRadio.checkRadioSizeMaxHeightSelectorOnly == MockThemeCheckRadioComponentTokenProvider.mockThemeCheckRadioDimension)
XCTAssertNotEqual(inheritedTheme.checkRadio.checkRadioSizeSelectorMaxHeightSelectorOnly, abstractTheme.checkRadio.checkRadioSizeSelectorMaxHeightSelectorOnly)

Check failure on line 52 in OUDS/Core/Themes/Orange/Tests/Values/ComponentTokens/TestThemeOverrideOCheckRadioComponentTokens.swift

View workflow job for this annotation

GitHub Actions / unit-test

value of type 'any AllCheckRadioComponentTokensProvider' has no member 'checkRadioSizeSelectorMaxHeightSelectorOnly'

Check failure on line 52 in OUDS/Core/Themes/Orange/Tests/Values/ComponentTokens/TestThemeOverrideOCheckRadioComponentTokens.swift

View workflow job for this annotation

GitHub Actions / unit-test

value of type 'any AllCheckRadioComponentTokensProvider' has no member 'checkRadioSizeSelectorMaxHeightSelectorOnly'
XCTAssertTrue(inheritedTheme.checkRadio.checkRadioSizeSelectorMaxHeightSelectorOnly == MockThemeCheckRadioComponentTokenProvider.mockThemeCheckRadioDimension)

Check failure on line 53 in OUDS/Core/Themes/Orange/Tests/Values/ComponentTokens/TestThemeOverrideOCheckRadioComponentTokens.swift

View workflow job for this annotation

GitHub Actions / unit-test

value of type 'any AllCheckRadioComponentTokensProvider' has no member 'checkRadioSizeSelectorMaxHeightSelectorOnly'
}

func testInheritedThemeCanOverrideCheckRadioComponentTokenSizeMaxHeightAssetsContainer() throws {
XCTAssertNotEqual(inheritedTheme.checkRadio.checkRadioSizeMaxHeightAssetsContainer, abstractTheme.checkRadio.checkRadioSizeMaxHeightAssetsContainer)
XCTAssertTrue(inheritedTheme.checkRadio.checkRadioSizeMaxHeightAssetsContainer == MockThemeCheckRadioComponentTokenProvider.mockThemeCheckRadioDimension)
XCTAssertNotEqual(inheritedTheme.checkRadio.checkRadioSizeSelectorMaxHeightAssetsContainer, abstractTheme.checkRadio.checkRadioSizeSelectorMaxHeightAssetsContainer)
XCTAssertTrue(inheritedTheme.checkRadio.checkRadioSizeSelectorMaxHeightAssetsContainer == MockThemeCheckRadioComponentTokenProvider.mockThemeCheckRadioDimension)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ public protocol CheckRadioComponentTokens {

// MARK: - Sizes

var checkRadioSize: SizeSemanticToken { get }
var checkRadioSizeSelector: SizeSemanticToken { get }

// MARK: - Dimensions

var checkRadioSizeMinHeightSelectorOnly: DimensionRawToken { get }
var checkRadioSizeMinWidthSelectorOnly: DimensionRawToken { get }
var checkRadioSizeMaxHeightSelectorOnly: DimensionRawToken { get }
var checkRadioSizeMaxHeightAssetsContainer: DimensionRawToken { get }
var checkRadioSizeMinHeightSelectorOnly: SizeSemanticToken { get }
var checkRadioSizeMinWidthSelectorOnly: SizeSemanticToken { get }
var checkRadioSizeMaxHeightSelectorOnly: SizeSemanticToken { get }
var checkRadioSizeMaxHeightAssetsContainer: SizeSemanticToken { get }
}

// swiftlint:enable missing_docs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ They can be seen as a kind of bridge between components and in the end primitive

<!-- NOTE: Do not forget to update tokens version -->
```
🧱 Tokens version: v0.4.0
🧱 Tokens version: v0.4.1
```

Thus if a component need to change for example its _background color_, and if a _component token_ is used for it, then only the value of this _token_ should be changed without any modification on the _component_ definition.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ _Raw tokens_ are smallest _tokens_ possible. They are associated to raw values a

<!-- NOTE: Do not forget to update tokens version -->
```
🧱 Tokens version: v0.4.0
🧱 Tokens version: v0.4.1
```

In fact, we choose to use as most as possible primitive types for raw values, like `Int`, `Double`, `CGFloat` or `String` so as to handle the smallest types with few impacts on the memory for ecodesign principles. Indeed with hundreds of raw tokens, it will be more efficient to store primitive small types than Swift `struct` or `class` objects. Keeping primitive types helps today to expose objects using Objective-C runtime.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ They can be seen as an high level of usage with functional meanings.

<!-- NOTE: Do not forget to update tokens version -->
```
🧱 Tokens version: v0.4.0
🧱 Tokens version: v0.4.1
```

If we need for example to change a warning color for a button (which has its component tokens, see [OUDSTokensComponent](https://ios.unified-design-system.orange.com/documentation/oudstokenscomponent/)), supposing this color is defined as a _semantic token_, we only have to change its assigned value and all components using the _semantic token_ won't be impacted in their definition. In fact, semantic tokens are here to bring meaning, semantic, between raw values and components.
Expand Down

0 comments on commit 0c84f73

Please sign in to comment.