Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test #440

Closed
wants to merge 4 commits into from
Closed

Test #440

wants to merge 4 commits into from

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Feb 3, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibiltiy review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

pylapp and others added 4 commits January 30, 2025 19:03
@pylapp
Prepare next release (#433)
c6c164f 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
docs: more details about commit body
e1f7590 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
ci: add configuration and details to build release note
2c79e5a 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@ludovic35 @pylapp
feat: add link component (#400) (#401)
3db0aaa 
Closes #400 

Tested-by: Benoit Suzanne <[email protected]>
Tested-by: Maxime Tonnerre <[email protected]>
Tested-by: Pierre-Yves Ayoul <[email protected]>
Reviewed-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp requested a review from ludovic35 as a code owner February 3, 2025 16:32
@pylapp pylapp closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovic35 ludovic35 Awaiting requested review from ludovic35 ludovic35 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pylapp @ludovic35