Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#36] Add dimension raw tokens and dimensions, spacings, sizings semantic tokens #63

Merged
merged 2 commits into from
Aug 7, 2024
Merged

[#36] Add dimension raw tokens and dimensions, spacings, sizings semantic tokens #63

merged 2 commits into from
Aug 7, 2024

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Aug 6, 2024 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#36

Description

Reviews dimension raw tokens and dimensions, spacings and sizings semantic tokens.
Add unit tests to check raw tokens order relationships and semantic tokens overridings.

Motivation & Context

See #36

Types of change

  • New feature (non-breaking change which adds functionality)

Definition of Done

Previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • (NA) Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@pylapp pylapp self-assigned this Aug 6, 2024
@pylapp pylapp requested a review from ludovic35 as a code owner August 6, 2024 15:11
@pylapp pylapp linked an issue Aug 6, 2024 that may be closed by this pull request
Tokens: Dimension #36
Closed
1 task
@pylapp pylapp marked this pull request as draft August 6, 2024 15:11
pylapp added 2 commits August 7, 2024 16:57
@pylapp
feat: add raw tokens and semantic tokens for dimensions, spacings, si…
f09d3aa 
…zings (#36)

This commit reviews values of raw tokens for dimensions.
It reviews also semantic tokens for dimensions, spacings and sizings.
Unit tests have been added to check tokens order relationships and overridings.

Closes #36

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor: clean code abse and improve tests for dimensions tokens (#36)
8cff7bd 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp force-pushed the 36-tokens-dimension branch from 62f82be to 8cff7bd Compare August 7, 2024 14:57
@pylapp pylapp removed a link to an issue Aug 7, 2024
Tokens: Dimension #36
Closed
1 task
@pylapp pylapp marked this pull request as ready for review August 7, 2024 14:58
@pylapp pylapp merged commit 5799e66 into develop Aug 7, 2024
4 checks passed
@pylapp pylapp deleted the 36-tokens-dimension branch August 7, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovic35 ludovic35 Awaiting requested review from ludovic35 ludovic35 is a code owner

Assignees

@pylapp pylapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pylapp