Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#51] Add raw and semantic tokens for typography #64

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Aug 6, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#51

Description

  • Review and update raw tokens for typographty
  • Review and update semantic tokens for typography
  • Add unit tests for raw tokens for typography (order relationship)
  • Add unit tests for semantic tokens for typography (overridings)
  • Tackle issue about font families
  • Tackle issue about letter spacings
  • Check if other issues must be investigated

Motivation & Context

See #51

Types of change

  • New feature (non-breaking change which adds functionality)

Previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • (NA) Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@pylapp pylapp self-assigned this Aug 6, 2024
@pylapp pylapp requested a review from ludovic35 as a code owner August 6, 2024 16:58
@pylapp pylapp linked an issue Aug 6, 2024 that may be closed by this pull request
1 task
@pylapp pylapp marked this pull request as draft August 6, 2024 16:58
@pylapp pylapp force-pushed the 51-tokens-typography branch from bd44d8a to 4d83ac6 Compare August 7, 2024 14:45
@pylapp pylapp removed a link to an issue Aug 7, 2024
1 task
@pylapp pylapp marked this pull request as ready for review August 7, 2024 14:46
@pylapp pylapp merged commit f4ec34d into develop Aug 7, 2024
4 checks passed
@pylapp pylapp deleted the 51-tokens-typography branch August 7, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant