fix(deps): clear 4 high Dependabot alerts (urllib3 + orjson) with setuptools<81 pin#8
Closed
mikejgray wants to merge 1 commit into
Closed
fix(deps): clear 4 high Dependabot alerts (urllib3 + orjson) with setuptools<81 pin#8mikejgray wants to merge 1 commit into
mikejgray wants to merge 1 commit into
Conversation
…uptools<81 pin - urllib3 2.3.0 → 2.6.3 (3 highs: decompression bomb redirects, streaming compression, unbounded link chain) - orjson 3.10.12 → 3.11.8 (deep recursion DoS) - setuptools pinned <81 — the high-sev alert (PackageIndex.download path traversal in easy_install) is build-time only and not invoked here. setuptools 81 removed --dry-run, 82 removed pkg_resources entirely; ovos-plugin-manager has importlib.metadata fallback but the OVOS dep chain hasn't been audited end-to-end for pkg_resources usage. All 42 tests pass, 83% coverage. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
dca8f12 to
03a842b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears 4 of 5 high-severity Dependabot alerts. setuptools high explicitly skipped — see below.
Why setuptools is pinned <81
The setuptools high-sev alert (path traversal in
PackageIndex.download) is exploitable only viaeasy_install, which we do not invoke. Meanwhile:--dry-runpkg_resourcesentirelyovos-plugin-manager.utilsfalls back topkg_resourcesifimportlib.metadata.entry_pointsimport fails. The fallback is dead code on Python 3.10+, but the broader OVOS dep chain hasn't been audited end-to-end forpkg_resourcesusage. The runtime risk of breaking the OVOS plugin discovery chain outweighs a build-time-only advisory we don't trigger.Will revisit once OVOS confirms
importlib.metadata-only paths.Test plan
uv run pytest— 42/42 pass, 83% coverage🤖 Generated with Claude Code