Skip to content

Code review findings: dialect mismatches, metadata correctness, and robustness fixes #2281

Description

@HandSonic

Comprehensive per-module code review (36 plugins + core layers) produced a verified issue list. This issue tracks the fix PRs, one per module.

Findings classes (each verified against code with a confirming caller path):

  • Dialect mismatch: SQL parser/DML from the wrong dialect (BigQuery on PG grammar, CockroachDB on MySQL grammar, Presto on MySQL grammar, MariaDB raw fallback, Kylin inheriting MySQL export statements)
  • Metadata correctness: opengauss deleting the default 'postgres' database and system schemas instead of marking them; generic MapStruct mapping leaving all supportXxx flags false; Presto tableDDL wrong SPI signature (overloads instead of overrides); Kylin tableDDL throwing UnsupportedOperationException
  • Oscar pagination: first page leaks the internal ROWNUM column CHAT2DB_AUTO_ROW_ID
  • Redis correctness: DEL with raw unquoted key names (can delete wrong keys), grid edits dropped by an empty loop, SCAN truncated after first batch, RENAME/EXPIRE raw names, all-fields-deleted hash left as no-op
  • domain-core: Excel-import DDL built with unescaped identifiers/comments; swallowed SQLExceptions; pinned tables duplicated on page 1; schema-less completion fallback using the wrong variable

Each PR fixes one module end-to-end with regression tests. Fixes were verified by module tests plus an adversarial review pass.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs/infoNeeds more information from the reporter

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions