bug(oscar): isReservedKeyword does not uppercase the identifier before lookup

[Aias00]

Description

OscarIdentifierProcessor.isReservedKeyword looks up the identifier in the all-uppercase RESERVED_KEYWORDS set without uppercasing it first, so a lowercase or mixed-case reserved word (e.g. select, Table) returns false, violating the SPI contract that every sibling dialect satisfies by uppercasing with Locale.ROOT.

The bug is masked only inside quoteIdentifier (which calls identifier.toUpperCase() before delegating), but any direct SPI caller (completion/metadata paths) gets the wrong answer, so lowercase reserved words would be left unquoted.

Location

chat2db-community-server/chat2db-community-plugins/chat2db-community-oscar/src/main/java/ai/chat2db/plugin/oscar/identifier/OscarIdentifierProcessor.java:28-30

@Override
public boolean isReservedKeyword(String identifier, Integer majorVersion, Integer minorVersion) {
    return RESERVED_KEYWORDS.contains(identifier);
}

Sibling idiom (DM/SUNDB/XUGUDB all uppercase + null-guard):

return identifier != null && RESERVED_KEYWORDS.contains(identifier.toUpperCase(Locale.ROOT));

Impact

Reserved-keyword identifiers reached via direct isReservedKeyword callers are returned unquoted; inconsistent dialect behavior. Masked in the quoteIdentifier path.

Suggested fix

Match the sibling idiom (uppercase with Locale.ROOT + null guard) and add import java.util.Locale;:

@Override
public boolean isReservedKeyword(String identifier, Integer majorVersion, Integer minorVersion) {
    return identifier != null && RESERVED_KEYWORDS.contains(identifier.toUpperCase(Locale.ROOT));
}

Related existing

None. No prior issue covers the Oscar reserved-keyword casing.

[github-actions]

Thanks for the precise report. The issue identifies the case-sensitive lookup in OscarIdentifierProcessor.isReservedKeyword, explains why quoteIdentifier masks it, and provides the expected Locale.ROOT normalization and null guard.

PR #2388 is linked from the issue and contains the focused fix. The next maintainer step is to review that change and confirm coverage for lowercase, mixed-case, and null identifiers.

Generated by AI Issue Assistant for #2385 · 6.01 AIC · ⌖ 4.38 AIC · ⊞ 16.4K · ◷