Skip to content

fix(sqlserver): add TOP/ROW_NUMBER pagination for SQL Server < 2012 (#1693) #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HandSonic wants to merge 1 commit into from
Closed

fix(sqlserver): add TOP/ROW_NUMBER pagination for SQL Server < 2012 (#1693) #1895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 27 additions & 12 deletions ...nity-sqlserver/src/main/java/ai/chat2db/plugin/sqlserver/builder/SqlServerSqlBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,19 +243,34 @@ public String buildPageLimit(PageLimitRequest request) {
String version = Chat2DBContext.getDbVersion();
if (StringUtils.isNotBlank(version)) {
String[] versions = version.split(VALUE_BACKSLASH_DOT);
if (versions.length > 0 && Integer.parseInt(versions[0]) >= 11) {
StringBuilder sqlBuilder = new StringBuilder(sql.length() + 14);
sqlBuilder.append(sql);
if (!sql.toLowerCase().contains(ORDER_BY_KEYWORD_LOWER)) {
sqlBuilder.append(SQL_ORDER_BY_OPEN_PAREN_SELECT_NULL_CLOSE_PAREN);
if (versions.length > 0) {
int majorVersion = Integer.parseInt(versions[0]);
if (majorVersion >= 11) {
// SQL Server 2012+: use OFFSET/FETCH NEXT
StringBuilder sqlBuilder = new StringBuilder(sql.length() + 14);
sqlBuilder.append(sql);
if (!sql.toLowerCase().contains(ORDER_BY_KEYWORD_LOWER)) {
sqlBuilder.append(SQL_ORDER_BY_OPEN_PAREN_SELECT_NULL_CLOSE_PAREN);
}
sqlBuilder.append(SQLConstants.LINE_SEPARATOR_OFFSET_SQL);
sqlBuilder.append(offset);
sqlBuilder.append(SQLConstants.ROWS_SQL);
sqlBuilder.append(SQLConstants.FETCH_NEXT_SQL);
sqlBuilder.append(pageSize);
sqlBuilder.append(SQLConstants.ROWS_ONLY_SQL);
return sqlBuilder.toString();
} else if (majorVersion >= 9) {
// SQL Server 2005-2008 R2: use ROW_NUMBER() OVER()
if (offset == 0) {
// First page: use TOP directly
return "SELECT TOP (" + pageSize + ") * FROM (" + sql + ") AS _page_query";
} else {
// Subsequent pages: use ROW_NUMBER() for offset
return "SELECT * FROM (SELECT *, ROW_NUMBER() OVER (ORDER BY (SELECT NULL)) AS _row_num "
+ "FROM (" + sql + ") AS _inner_query) AS _outer_query "
+ "WHERE _row_num > " + offset + " AND _row_num <= " + (offset + pageSize);
}
}
sqlBuilder.append(SQLConstants.LINE_SEPARATOR_OFFSET_SQL);
sqlBuilder.append(offset);
sqlBuilder.append(SQLConstants.ROWS_SQL);
sqlBuilder.append(SQLConstants.FETCH_NEXT_SQL);
sqlBuilder.append(pageSize);
sqlBuilder.append(SQLConstants.ROWS_ONLY_SQL);
return sqlBuilder.toString();
}
}
return SQLConstants.EMPTY;
Expand Down