fix(i18n): refresh setting.ts source hashes to repair Community CI on main - #1897
Closed
solitude-mix wants to merge 1 commit into
Closed
solitude-mix wants to merge 1 commit into
solitude-mix wants to merge 1 commit into
Conversation
PR OtterMind#1889 updated the Base URL hint in en-US/setting.ts together with the es-ES and ko-KR translations, but missed regenerating scripts/i18n-source-hashes.json, so the 'Validate localization catalogs' step now fails on main. Regenerated with node ./scripts/validate-i18n.cjs --write-source-hashes; the full validation passes locally.
Contributor
|
Verified the root cause: #1889 updated I reran |
Contributor
|
Thanks for the contribution. The target This PR is now obsolete, so I am closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1889 — repairs the
Community CIfailure onmain(Validate localization catalogs):What happened
#1889 changed the Base URL hint in
en-US/setting.tsand updated all five locale translations, but missed regeneratingchat2db-community-client/scripts/i18n-source-hashes.json, which pins a hash of each en-US module for the managedes-ES/ko-KRtranslations. Sinceci.ymltriggers onpushonly, the fork PR never ran this check and it surfaced after the merge. Sorry for the redmain.What changed
scripts/i18n-source-hashes.jsonregenerated withnode ./scripts/validate-i18n.cjs --write-source-hashes— the diff is exactly the two stalesetting.tsentries (the translations themselves were already updated in #1889).How I tested it
node ./scripts/validate-i18n.cjsreproduces the same 2 errors as the failed run.Validated es-ES and ko-KR against 25 frontend modules, 2 properties bundles, and 5 READMEs.— full validation passes (key sets, placeholder/tag contracts, properties bundles, and READMEs included).