fix(ai-setting): scope org store subscription to curOrg - #2040
Merged
Merged
Conversation
useOrgStore() subscribed to the whole org store. Use a scoped selector. Fixes OtterMind#2031 Co-Authored-By: Claude <noreply@anthropic.com>
openai0229
approved these changes
Jul 24, 2026
openai0229
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the scoped org-store selector. It preserves the value contract and removes unrelated store subscriptions; no blocking issue found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2031
Summary
AISettingreadconst { curOrg } = useOrgStore();, subscribing to the entire org store. The component re-rendered on every org-store change instead of only whencurOrgchanged. Changed to a scoped selector:const curOrg = useOrgStore((s) => s.curOrg);. Downstream usage (curOrg?.roleCodes) is unchanged.Affected surfaces
Verification
npx tsc --noEmit -p chat2db-community-client/tsconfig.json— no errors forAISetting/index.tsx.curOrgis a direct field on the org store.Risk and compatibility
Reviewer map
blocks/Setting/AISetting/index.tsx:24—const { curOrg } = useOrgStore();->const curOrg = useOrgStore((s) => s.curOrg);.Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.