fix(canvas-table): unmount cell-editor React root on end - #2076
Merged
openai0229 merged 2 commits intoJul 24, 2026
Merged
Conversation
createElement called ReactDOM.createRoot(...).render(...) and discarded the root; onEnd only removed the DOM node, so the React fiber tree leaked on every cell-edit open/close. Store the root on the instance and unmount it in onEnd (both InputEditor and DateEditor createElement sites). Fixes OtterMind#2070 Co-Authored-By: Claude <noreply@anthropic.com>
openai0229
approved these changes
Jul 24, 2026
openai0229
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the React root ownership and unmount lifecycle across the canvas table editors. No blocking findings; LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2070
Summary
In
InputIEditor,createElementcalledReactDOM.createRoot(inputContainer).render(...)inline and discarded the root reference.onEndonly detached the DOM node (removeChild) — the React fiber tree, state, effects, and handlers inside the rendered component were never torn down, leaking on every cell-edit open/close cycle. Now the root is stored on the instance (this.root) andunmount()ed inonEnd(andthis.rootnulled). Applied at both createElement sites: the baseInputEditorandDateEditor.createElement(the date editor inherits the baseonEnd, andcreateElementis only invoked wheninputContaineris null, so there is no double-create that would orphan a prior root).Affected surfaces
Verification
npx tsc --noEmit -p chat2db-community-client/tsconfig.json— no errors forInputIEditor/index.tsx.npx eslint src/blocks/CanvasTable/editor/InputIEditor/index.tsx— no errors.onEnd,this.root?.unmount()is now called (tearing down the React tree), andthis.rootis nulled.createElementis guarded byif (!this.inputContainer)so it is not called twice without an interveningonEnd.Risk and compatibility
onEnd; edit/create behavior unchanged.Reviewer map
blocks/CanvasTable/editor/InputIEditor/index.tsx— newrootfield onInputEditor; bothcreateElementsites storethis.root = ReactDOM.createRoot(...)thenthis.root.render(...);onEndcallsthis.root?.unmount()and nulls it.Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.