fix(chat-question-template): guard example-prompt fetch against unmount - #2086
Merged
openai0229 merged 3 commits intoJul 25, 2026
Merged
Conversation
The mount-only effect started an async fetch that called setExamplePromptList after await with no mounted guard, firing setState on an unmounted component. Track a mounted ref and skip setState after unmount. Fixes OtterMind#2081 Co-Authored-By: Claude <noreply@anthropic.com>
openai0229
approved these changes
Jul 25, 2026
openai0229
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the latest frontend-only head. The unmount guard is scoped correctly, and the relevant frontend build/lint/test and JavaScript CodeQL checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2081
Summary
In
chatQuestionTemplate, a mount-onlyuseEffectcalledqueryExamplePrompt, whichawaitschatService.queryChatExamplePrompt({})and then callssetExamplePromptList(res)with no mounted guard. If the component unmounted before the promise resolved,setStatefired on an unmounted component. Added amountedRef(useRef(true), setfalsein the mount effect's cleanup) and guardif (res && mountedRef.current)beforesetState, mirroring the NotificationNav pattern.Affected surfaces
Verification
npx tsc --noEmit -p chat2db-community-client/tsconfig.json— no errors forchatQuestionTemplate/index.tsx.npx eslint src/pages/main/chat/chatQuestionTemplate/index.tsx— no errors.mountedRef.current === falseskips thesetExamplePromptListcall.Risk and compatibility
setStateafter unmount; mounted behavior unchanged.Reviewer map
pages/main/chat/chatQuestionTemplate/index.tsx—mountedRef = useRef(true), mountuseEffectsets it true and clears it in cleanup, andqueryExamplePromptguardsif (res && mountedRef.current).setExamplePromptListstill fires on an unmounted component during the on-mount fetch.Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.