fix(sql-editor): sync action state on content changes - #2263
Merged
Merged
Conversation
openai0229
force-pushed
the
fix/2259-sync-editor-action-state
branch
from
July 27, 2026 13:19
11aa12c to
709cca8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2259
Summary
Synchronize SQL editor toolbar availability directly from Monaco model changes instead of waiting for the existing 300 ms debounced value callback.
The new
onContentChangepath is intentionally limited to lightweight UI state. SQL parsing, completion, parameter hints, and the existing externalonChangebehavior remain on the debounced path, preserving the editor's performance boundary while covering paste, deletion, undo, redo, and programmatic model updates.Affected surfaces
Verification
yarn eslint src/components/SQLEditor/editor/MonacoEditor/index.tsx src/components/SQLEditor/editor/SQLEditor/index.tsx src/components/SQLEditor/editor/SQLEditorWithOperation/index.tsx --max-warnings=0- passedyarn lint- passedyarn test:i18n- passedyarn build:web:community --app_version=5.3.0- passed, including all Community prebuild testsgit diff --check- passed8890;/workspaceand the frontend-proxied/api/systemboth returned HTTP 200. Interactive paste automation was unavailable in the current browser environment.Risk and compatibility
onChangecallback is unchanged. The new optional callback only synchronizes lightweight content-presence state.Reviewer map
chat2db-community-client/src/components/SQLEditor/editor/MonacoEditor/index.tsx, insideonDidChangeModelContent.Contributor declaration
AI assistance: Substantial AI assistance was used for source tracing, implementation, and verification.