fix(core-domain-api): volatile async state, escape quoted SQL values, fix XLXS typo, align PinTable hashCode - #2293
Merged
Conversation
… fix XLXS typo, align PinTable hashCode (code review follow-up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Four defects in domain-api:
XLXS(".xlxs")— exported Excel files got the misspelled.xlxssuffix.DataTypeEnum.getValuewrapped values in single quotes directly ("'" + value + "'") for BOOLEAN-fallback, DATETIME, CONTENT, STRUCT, DOCUMENT, ARRAY, OBJECT, REFERENCE, ROWID, ANY, and UNKNOWN — any value containing',", or\produced broken or injectable SQL.finish,progress,info, anderrorare written by a worker thread and polled from another thread, but were notvolatile— the poller could spin forever on a stalefinish=false.PinTableoverridesequalsbut nothashCode, so equal instances landed in different hash buckets andHashMap/HashSet/containsbehaved incorrectly.Fix
XLSX(".xlsx")getStringValue, which escapes\,', and"before quotingAsyncContextfieldsvolatilePinTable.hashCodeover the same fields used byequalsTests
New
ExportFileSuffixEnumTest,DataTypeEnumTest,AsyncContextTest,PinTableTest(junit-jupiter added to module test scope).mvn teston chat2db-community-domain-api: 11/11 pass.Verified on fork HandSonic#22 (meaningful CI checks green; dependency-review/project-sync jobs are fork-permission noise). Regression tests pass; adversarial review cleared.