fix(cookie): make LocalCookie flush thread a named daemon - #2522
Merged
openai0229 merged 5 commits intoSep 11, 2026
Merged
Conversation
…2521) The static initializer started a permanent while(true) cleanup loop as a non-daemon thread, so the JVM could not exit cleanly once the class was loaded. Mark it as a daemon and name it chat2db-local-cookie-flush. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: liuhy <liuhongyu@apache.org>
Constraint: Preserve existing PR behavior while refreshing the merge base Confidence: high Scope-risk: narrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Static initializer started a permanent
while(true)cleanup loop as a non-daemon thread — JVM could not exit cleanly.Location
chat2db-community-tools/.../http/LocalCookie.java:48-64Fix
setDaemon(true)+ namechat2db-local-cookie-flush(same pattern as #2386 ConnectionPool).Fixes #2521
🤖 Generated with Claude Code