feat(mysql): import preview and column mapping (#2600) by Aias00 · Pull Request #2652 · OtterMind/Chat2DB

Aias00 · 2026-08-07T08:39:13Z

Summary

Preview endpoint: bounded rows (first row = header) + source fields/samples + target columns (type/nullable/default/auto-increment) + suggested mapping by exact name.
Mapping import: remap/skip source fields, unmapped target columns use DEFAULT or explicit NULL; unmapped NOT NULL no-default columns block execution before any write.
Per-row continue-on-error with source row / target column / message; numeric/date coercion; totals + row errors returned.
Import modal shows the mapping step after file selection (preview table + mapping selects + strategy + result summary).
i18n ×5 + MYSQL-IMPORT-001 fixtures (reordered, extra-column, strict-table CSV samples).

Test plan

Run MYSQL-IMPORT-001 README verification (auto mapping, reordered, skip extra column, NOT NULL block, DEFAULT/NULL strategy, invalid numeric row, large-file bounded preview)

- Bounded preview endpoint (CSV/XLS/XLSX via the same EasyExcel reader as execution): source fields with sample values, target columns with type/ nullable/default, and a suggested mapping by exact name match. - Mapping-driven import: remap source fields to target columns, skip source fields, fill unmapped target columns with DEFAULT or explicit NULL; NOT NULL columns without a default block execution before any write when unmapped. - Row-level error reporting (source row, target column, message) with per-row continue-on-error; type coercion for numeric/date columns. - Import modal gains a mapping step after file selection; i18n in all five locales and MYSQL-IMPORT-001 fixtures (reordered/extra columns, strict table, CSV samples).

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

openai0229 · 2026-08-19T11:48:25Z

Follow-up review after the latest main integration: changes are still requested before merge.

The current DbImportPreviewServiceImpl still reads the entire client-supplied path with Files.readAllBytes(), does not restrict that path, and executes the import synchronously outside the TaskService workflow. The DEFAULT path omits unmapped columns from the INSERT but still binds every target column, so parameter counts diverge; skippedCount remains zero and executeBatch() is called once per row without a defined transaction/partial-failure policy. Please fix these shared execution semantics in the cumulative import branch and rerun CI.

Constraint: preserve the PR's preview/mapping flow while adopting main's task submission and artifact handling Rejected: dropping preview mapping | would silently remove the feature under review Confidence: high Scope-risk: narrow Tested: NODE_PATH=/Users/aias/Work/github/Chat2DB/chat2db-community-client/node_modules node ./scripts/validate-i18n.cjs --write-source-hashes; git diff --cached --check

# Conflicts: # chat2db-community-client/scripts/i18n-source-hashes.json

…import-preview-2600

Signed-off-by: liuhy <liuhongyu@apache.org>

…import-preview-2600

Copilot AI lite review requested due to automatic review settings August 7, 2026 08:39

Aias00 requested a review from openai0229 as a code owner August 7, 2026 08:39

Copilot AI reviewed Aug 7, 2026

openai0229 added this to Chat2DB Community Aug 7, 2026

openai0229 moved this to In Review in Chat2DB Community Aug 7, 2026

merge: integrate origin/main (i18n source hashes synced)

666e021

This was referenced Aug 19, 2026

feat(mysql): CSV encoding and format options (#2601) #2653

Merged

feat(mysql): Excel sheet/header/NULL options (#2602) #2654

Open

Aias00 added 3 commits August 19, 2026 05:14

Merge remote-tracking branch 'origin/main' into pr2652-fix

c531336

# Conflicts: # chat2db-community-client/scripts/i18n-source-hashes.json

fix(import): align preview execution with metadata API

f8fb9ce

Aias00 requested a review from a team as a code owner August 23, 2026 06:36

github-advanced-security Bot found potential problems Aug 23, 2026

View reviewed changes

Comment thread ...-core/src/main/java/ai/chat2db/community/domain/core/impl/db/DbImportPreviewServiceImpl.java Fixed

Aias00 added 2 commits August 23, 2026 03:29

fix(import): stage preview files for task execution

090dc66

fix(i18n): refresh workspace source hashes

e145c30

github-advanced-security Bot found potential problems Aug 23, 2026

View reviewed changes

fix(mysql): harden import preview file registry

fdc20b0

github-advanced-security Bot found potential problems Aug 24, 2026

View reviewed changes

Comment thread ...-community-server/chat2db-community-spi/src/main/java/ai/chat2db/spi/DefaultSQLExecutor.java Fixed

Aias00 added 7 commits August 23, 2026 22:28

Fix CodeQL SQL executor alert scope

578bb04

Suppress intentional SQL executor CodeQL alert

1a6765f

chore(codeql): use parseable SQL suppression

948e97e

Merge main into import preview PR

06f012b

Merge remote-tracking branch 'origin/main' into ci-fix/feature/mysql-…

aad56f9

…import-preview-2600

chore(codeql): mark approved SQL executor sinks

4d75722

fix(codeql): isolate intentional SQL executor inputs

f25f824

github-advanced-security Bot found potential problems Aug 26, 2026

View reviewed changes

Comment thread ...-community-server/chat2db-community-spi/src/main/java/ai/chat2db/spi/DefaultSQLExecutor.java Fixed

Comment thread ...-community-server/chat2db-community-spi/src/main/java/ai/chat2db/spi/DefaultSQLExecutor.java Fixed

Aias00 added 2 commits August 30, 2026 21:54

fix(import): batch mapped data file writes

a3a007c

Signed-off-by: liuhy <liuhongyu@apache.org>

Merge origin/main into feature/mysql-import-preview-2600

eb0dc01

Signed-off-by: liuhy <liuhongyu@apache.org>

Aias00 and others added 18 commits August 31, 2026 23:24

fix(import): resolve trusted preview metadata

1c46539

Signed-off-by: liuhy <liuhongyu@apache.org>

feat(mysql): complete import task outcomes

b8fd371

Signed-off-by: liuhy <liuhongyu@apache.org>

Merge remote-tracking branch 'origin/main' into HEAD

4a1b12f

Signed-off-by: liuhy <liuhongyu@apache.org>

fix(import): bind preview request body

dade42f

Merge remote-tracking branch 'origin/main' into ci-fix/feature/mysql-…

88fb66a

…import-preview-2600

Merge main and verify bounded import preview

a2e550f

fix(import): generalize preview and column mapping

4810b06

fix(import): validate duplicate column mappings

1eea4f5

fix(import): simplify preview validation and execution

9b80790

fix(import): keep preview workflow focused

4508cdb

fix(import): validate preview execution contract

156bd17

fix(import): resolve target tables from metadata

2cdbdd0

fix(import): hide development file path override

73e0c24

fix(import): remove stale preview refresh

9baf1bb

fix(import): support web JSON and SQL uploads

ac15881

Merge origin/main into feature/mysql-import-preview-2600

5c8fb78

refactor(import): clarify staging and service boundaries

9e16e97

Merge latest origin/main into feature/mysql-import-preview-2600

cdf461f

openai0229 merged commit 76f3340 into OtterMind:main Sep 8, 2026
16 checks passed

openai0229 moved this from In Review to Done in Chat2DB Community Sep 8, 2026

openai0229 mentioned this pull request Sep 8, 2026

fix(import): enable preview in desktop runtimes #2887

Merged

10 tasks

Navigation Menu

feat(mysql): import preview and column mapping (#2600) - #2652

feat(mysql): import preview and column mapping (#2600)#2652
openai0229 merged 35 commits into
OtterMind:mainfrom
Aias00:feature/mysql-import-preview-2600

Aias00 commented Aug 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

openai0229 commented Aug 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Aias00 commented Aug 7, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

openai0229 commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openai0229 commented Aug 19, 2026 •

edited

Loading