fix(client): preserve selected result page size - #2750
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Community SQL result pagination size selector reverting to 1000 after a new size is selected.
Root cause
The result toolbar updated its local React state and then scheduled SQL execution with
setTimeout(0). The execution path read pagination through an imperative ref before the new state render was guaranteed to commit, so selecting5000could still sendpageSize=1000. The response then copied the old execution parameters and reset the selector back to1000.Changes
{ pageNo, pageSize }directly through the toolbar operation callback.setTimeoutrace.executeSqlParams.Expected behavior
5000immediately sendspageSize=5000and resets to page 1.Verification
git diff --checkpassed.