Skip to content

fix(client): make long result cells readable without unbounded rows - #2754

Merged
openai0229 merged 1 commit into
mainfrom
fix/result-cell-overflow-rework
Aug 25, 2026
Merged

openai0229 merged 1 commit into
mainfrom
fix/result-cell-overflow-rework

Conversation

@openai0229

Copy link
Copy Markdown
Contributor

Summary

Rework the merged #2752 result-cell fix so ordinary long SQL/DDL values remain complete without allowing one row to grow without bound.

Root cause

The previous PR only enabled VTable auto wrapping and auto row height. VTable still applied its default maxCharactersNumber = 200 before measuring or rendering text, so the row expanded around an already-truncated value. defaultRowHeight: 'auto' was also redundant once heightMode: 'autoHeight' is enabled.

Changes

  • Keep autoWrapText and heightMode: 'autoHeight' scoped to ResultSetTable.
  • Set maxCharactersNumber to Number.MAX_SAFE_INTEGER so ordinary result text is not truncated by VTable. Existing largeValue metadata rendering and chunked value viewing are unchanged.
  • Cap automatically calculated body rows at 240px after VTable rendering. Rows recorded by VTable as manually resized are left untouched, so dragging a row boundary reveals more content.
  • Replace the previous layout-only regression assertion with coverage for the effective layout contract and automatic/manual row-height behavior.

Verification

  • yarn test:result-table-layout
  • yarn test:result-set-ui (35/35)
  • Targeted ESLint with --max-warnings=0
  • Community production Webpack compilation
  • git diff --check

@openai0229
openai0229 requested review from a team and Aias00 as code owners August 24, 2026 13:58
@openai0229 openai0229 moved this to In Review in Chat2DB Community Aug 24, 2026
@openai0229
openai0229 merged commit 1e0eb84 into main Aug 25, 2026
19 checks passed
@openai0229
openai0229 deleted the fix/result-cell-overflow-rework branch August 25, 2026 07:16
@openai0229 openai0229 moved this from In Review to Done in Chat2DB Community Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant