fix(client): make long result cells readable without unbounded rows - #2754
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rework the merged #2752 result-cell fix so ordinary long SQL/DDL values remain complete without allowing one row to grow without bound.
Root cause
The previous PR only enabled VTable auto wrapping and auto row height. VTable still applied its default
maxCharactersNumber = 200before measuring or rendering text, so the row expanded around an already-truncated value.defaultRowHeight: 'auto'was also redundant onceheightMode: 'autoHeight'is enabled.Changes
autoWrapTextandheightMode: 'autoHeight'scoped toResultSetTable.maxCharactersNumbertoNumber.MAX_SAFE_INTEGERso ordinary result text is not truncated by VTable. ExistinglargeValuemetadata rendering and chunked value viewing are unchanged.Verification
yarn test:result-table-layoutyarn test:result-set-ui(35/35)--max-warnings=0git diff --check