Skip to content

fix(client): stabilize database tree horizontal scrolling - #2758

Merged
openai0229 merged 2 commits into
mainfrom
fix/tree-horizontal-scroll
Aug 25, 2026
Merged

openai0229 merged 2 commits into
mainfrom
fix/tree-horizontal-scroll

Conversation

@openai0229

Copy link
Copy Markdown
Contributor

Summary

  • replace the legacy max-content, inherited positioning, and visible-overflow overrides with rc-virtual-list horizontal scrolling
  • measure rendered tree-title widths while preserving vertical virtualization, including virtual horizontal-offset compensation
  • reset stale width ranges when tree data, expansion state, editing state, or panel width changes, while accumulating wider nodes during vertical browsing
  • keep the horizontal scrollbar at the bottom, hide it while idle, and keep it visible during thumb dragging
  • add focused tests for width calculation, measurement-cycle reset, and virtual-scroll offset handling

Root cause

The previous CSS-based approach forced content sizing through multiple internal Ant Tree and virtual-list layers. Those overrides conflicted with virtualization: horizontal wheel events were consumed by the inner list, stale outer offsets clipped expand icons, and narrow panels could not scroll reliably.

Validation

  • yarn test:tree-loading
  • targeted ESLint for the changed NewTree files
  • git diff --check
  • Community JCEF Webpack hot-reload compilation and manual narrow-panel verification

Notes

The repository-wide yarn tsc --noEmit --pretty false command still reports existing unrelated type errors across the frontend; it reported no new error in the files changed by this PR.

@openai0229
openai0229 requested a review from a team as a code owner August 25, 2026 05:33
@openai0229 openai0229 moved this to In Review in Chat2DB Community Aug 25, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit f3756fb. Findings: 0 critical, 0 high, 1 medium. The horizontal scrollbar cannot be initiated by pointer drag while idle because pointer events are disabled; please address the linked finding. Merge recommendation: comment pending that fix. Coverage limit: read-only review of the current GitHub diff and metadata; no code, tests, or runtime checks were executed.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by AI Pull Request Reviewer for #2758 · 7.32 AIC · ⌖ 2.74 AIC · ⊞ 16.6K

Comment thread chat2db-community-client/src/blocks/NewTree/style.ts Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit 0da6224. Findings: 0 critical, 0 high, 0 medium. Merge recommendation: no actionable findings; the prior scrollbar pointer-events finding is addressed by the current diff. Coverage limit: read-only inspection of the current GitHub metadata, diff, reviews, and line comments; no code, tests, or runtime checks were executed.

``

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by AI Pull Request Reviewer for #2758 · 3.96 AIC · ⌖ 2.69 AIC · ⊞ 38.8K

@openai0229
openai0229 force-pushed the fix/tree-horizontal-scroll branch from 0da6224 to 2bab556 Compare August 25, 2026 07:23
@openai0229
openai0229 merged commit 808546a into main Aug 25, 2026
14 checks passed
@openai0229
openai0229 deleted the fix/tree-horizontal-scroll branch August 25, 2026 07:33
@openai0229 openai0229 moved this from In Review to Done in Chat2DB Community Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant