fix(client): preserve tab content across split panes - #2760
Merged
Merged
Conversation
openai0229
force-pushed
the
fix/workspace-split-pane-lifecycle
branch
from
August 25, 2026 08:07
93fc852 to
2ec8c08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Workspace tab bodies were rendered inside each pane-specific Tabs component. Creating or collapsing a SplitPane changed their React parent hierarchy, which unmounted and remounted editors, query results, and terminals even when the tab IDs did not change. Batching the store update prevented an intermediate state but could not preserve component instances.
Validation
yarn test:workspace-split-lifecycleyarn test:workspace-tab-dragyarn test:terminalyarn test:editor-closeyarn test:community-boundarygit diff --checkOut of scope
The existing visual header flash when the last tab closes and a pane collapses is intentionally unchanged.