fix(client): render first workspace terminal tab - #2789
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2788
Summary
Re-run workspace pane measurement when the workspace tab count changes. An empty workspace does not render the split-box ref, so the initial layout effect exits early. Opening the first terminal keeps the normalized split layout null, which previously prevented the effect from running again and left the terminal body hidden without pane bounds.
The added dependency initializes pane bounds and the resize observer when the first tab mounts. The fix is shared workspace lifecycle behavior and does not add terminal-specific or commercial product branching.
Affected surfaces
Verification
yarn test:workspace-split-lifecycle- passed.yarn lint- passed with zero warnings.yarn run build:web:community --app_version=0.0.0- passed, including the configured Community prebuild test suite and production bundle verification.yarn run build:web:desktop --app_version=5.3.5in Chat2DB Studio - passed; 212 bundled endpoints, 180 normalized paths, 354 backend owners, and the Pro composition bundle were verified.mvn clean package -f chat2db-studio-server/pom.xml -Dchat2db.product=pro -Pbridge-fat- passed with Studio Maven tests.Risk and compatibility
Reviewer map
chat2db-community-client/src/pages/main/workspace/components/WorkspaceTabs/index.tsx, at the pane-content measurementuseLayoutEffectdependency list.paneContentBoundsempty, so the active tab body remains hidden.38cbb9e3aa02b56e24933b9a39ea324473283f65.Contributor declaration
AI assistance: Substantial AI assistance was used for runtime diagnosis, implementation, and verification.