fix(storage): honor local datasource filters - #2820
Merged
openai0229 merged 2 commits intoSep 15, 2026
Merged
Conversation
10 tasks
HandSonic
force-pushed
the
fix/local-datasource-filters
branch
from
August 30, 2026 14:23
e50267a to
264c19b
Compare
HandSonic
force-pushed
the
fix/local-datasource-filters
branch
from
September 3, 2026 18:47
264c19b to
7191e49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - this defect was found during review of local datasource pagination; no public issue currently tracks it.
Summary
PRIVATEandSHAREDkind codes case-insensitively.Affected surfaces
Verification
mvn -B -ntp -f chat2db-community-server/pom.xml -pl :chat2db-community-storage -am -Dmaven.test.skip=false -DskipTests=false '-Dsurefire.includes=**/*Test.java' -Dsurefire.failIfNoSpecifiedTests=false -Dmaven.test.failure.ignore=false package. Test JVM home/temp directories were isolated.Risk and compatibility
LocalWorkspaceStorage; other storage implementations and editions are unchanged.Reviewer map
@openai0229(default CODEOWNER for community storage).LocalWorkspaceStorage.listDataSources, then the three filter-focused cases inLocalWorkspaceStorageDataSourceFilterTest.PRIVATE.7191e49bd0a96a88d1e786558bc6a54714e77147; there is no runtime flag because this makes existing request fields effective for local storage.Contributor declaration
AI assistance: Substantial AI assistance was used for implementation, tests, and adversarial review; the resulting diff and test evidence were manually inspected.