fix(storage): publish namespace positions atomically - #2846
Merged
openai0229 merged 2 commits intoSep 17, 2026
Merged
Conversation
HandSonic
force-pushed
the
fix/namespace-position-atomic
branch
2 times, most recently
from
September 3, 2026 08:08
b4a8bef to
c264c4e
Compare
HandSonic
force-pushed
the
fix/namespace-position-atomic
branch
from
September 3, 2026 21:07
c264c4e to
25ada3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no matching issue was found.
Summary
Namespace datasource-position operations mutated live
datasourceIdslists before persistence. A write failure left memory moved/deleted while disk and reload state remained old. This change deep-copies the complete namespace map, persists the candidate first, publishes one volatile map reference, and preserves null namespace as move-to-root.Affected surfaces
Verification
Risk and compatibility
Reviewer map
NamespaceStorage.copyDataMap/persistPositionsand atomic-write tests.25ada3b790c0649857cb733aa4caa792f4ccb2ef; no migration is required.Contributor declaration
AI assistance: OpenAI Codex assisted with diagnosis, implementation, deterministic tests, verification, and adversarial review.
Latest-main revalidation (2026-09-04)