Skip to content

fix(community): make file save lifecycle deterministic - #2861

Merged
openai0229 merged 6 commits into
mainfrom
fix/community-local-file-save-lifecycle
Sep 1, 2026
Merged

openai0229 merged 6 commits into
mainfrom
fix/community-local-file-save-lifecycle

Conversation

@openai0229

@openai0229 openai0229 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@openai0229
openai0229 requested review from a team and Aias00 as code owners September 1, 2026 04:09
@openai0229 openai0229 moved this to In Review in Chat2DB Community Sep 1, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5881399.

Findings: 0 critical, 1 high, 0 medium. Merge recommendation: request changes because path aliases can bypass the per-file save queue and allow stale content to overwrite a newer save. Coverage was limited to the GitHub-provided current diff and PR metadata; no tests or runtime checks were run.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by AI Pull Request Reviewer for #2861 · 12.8 AIC · ⌖ 2.8 AIC · ⊞ 17K

Comment thread chat2db-community-client/src/utils/localFileSaveCoordinator.ts Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 55ba6cd. Findings: 0 critical, 1 high, 0 medium. Merge recommendation: request changes because the post-save state update can overwrite concurrent rename or encoding metadata with a stale render-time snapshot, causing later saves to target the wrong file. Coverage was limited to the GitHub-provided current diff, PR metadata, existing reviews, and line comments; no tests or runtime checks were run. ``

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by AI Pull Request Reviewer for #2861 · 7.1 AIC · ⌖ 2.84 AIC · ⊞ 20.1K

@github-actions
github-actions Bot dismissed their stale review September 1, 2026 11:30

Superseded by updated review from same workflow.

@openai0229
openai0229 dismissed github-actions[bot]’s stale review September 1, 2026 11:58

Fixed in 368aaee. The follow-up AI review workflow completed agent, detection, safe_outputs, and conclusion successfully with no new findings; the stale full-state save write was replaced by a ddl-only delta merged with latest Workspace file metadata and covered by liveEditorBoundInfo.test.ts.

@openai0229
openai0229 merged commit 043bf4b into main Sep 1, 2026
23 checks passed
@openai0229
openai0229 deleted the fix/community-local-file-save-lifecycle branch September 1, 2026 12:32
@openai0229 openai0229 moved this from In Review to Done in Chat2DB Community Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant