fix(result): lazy-load large text values - #2882
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - no existing issue covers this regression.
Summary
Treat text-like and binary values larger than 10 KiB as lazy-loaded cells and keep only a 200-character preview in initial query results. This prevents large JSON/JSONB result pages from exceeding the desktop response serializer's large-object limit.
Keep large-value identity and actions intact when JSON is formatted or compressed in the value inspector, and reset the editor viewport to the start of the transformed content.
Affected surfaces
Verification
yarn eslint src/blocks/SearchResult/components/ViewData/index.tsx src/blocks/SearchResult/components/ViewData/JsonAwareMonacoEditor.tsx- passed.yarn tsx src/blocks/SearchResult/components/ViewData/largeCellValue.test.ts- passed.mvn -B -f chat2db-community-server/pom.xml -pl :chat2db-community-spi,:chat2db-community-domain-core -am -Dmaven.test.skip=false -DskipTests=false -Dtest=JDBCDataValueLargeCellTest,LargeValueTokenServiceTest -Dsurefire.failIfNoSpecifiedTests=false -Dmaven.test.failure.ignore=false test- 12 tests passed.Risk and compatibility
Reviewer map
JDBCDataValue.buildResultCellfor threshold/preview behavior, thenViewData.applyJsonPresentationfor inspector state.Contributor declaration
AI assistance: Substantial AI assistance was used for diagnosis, implementation, review, and test execution.