fix(frontend): prevent duplicate datasource mutations - #2891
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A - reported from a user reproduction video.
Summary
Prevent rapid repeated save/update actions from creating duplicate datasources. Serialize position changes per tree node, refresh the complete datasource tree after the server confirms a move, and leave the displayed tree unchanged when a move fails.
Affected surfaces
Verification
yarn test:data-source-mutation-refreshpassed;yarn lintpassed;yarn build:web:community --app_version=0.0.0passed, including the full prebuild suite and production bundle verification; the clean-worktree Community backend package also passed with tests skipped.Risk and compatibility
Reviewer map
src/components/ConnectionEdit/submissionGuard.tsandsrc/blocks/NewTree/treePositionMutation.ts.Contributor declaration
AI assistance: Codex analyzed the reproduction, implemented the frontend concurrency guards and server-authoritative refresh flow, added focused regression tests, and performed the isolated Playwright CLI regression.