fix(clipboard): preserve Windows line endings for result copies - #2909
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A
Summary
Windows native applications such as SAP GUI expect clipboard text rows to use CRLF. Result-set copies previously wrote LF-only text, which caused SAP paste to collapse rows and display
#markers. Normalize copied text to CRLF on Windows while preserving LF on macOS/Linux, and normalize internal result-grid matching so table paste keeps its cell metadata.Affected surfaces
Verification
yarn install --frozen-lockfile --non-interactive— passed in the PR worktree.yarn test:sql-in-clipboard— passed (clipboard normalization, internal grid clipboard, SQL-in clipboard, insert defaults).yarn lint— passed (ESLint and Stylelint).git diff --check— passed.Risk and compatibility
Reviewer map
chat2db-community-client/src/utils/clipboardText.tsandchat2db-community-client/src/utils/index.ts:292-325.\\r\\nbetween rows; internal result-grid paste must still recover the original matrix.34f061f56to restore the previous clipboard serialization.Contributor declaration
AI assistance: Codex performed source investigation, implementation, tests, browser regression verification, and packaging validation under maintainer direction.