fix(client): run an overdue update check when the window comes back - #2947
Merged
Merged
Conversation
A hidden renderer does not run its timers and macOS can nap the whole process, so the 30m/1h/2h/4h/6h schedule silently stopped while the app sat in the background. The schedule now remembers when the next check is due and runs it as soon as the window is visible and focused again, then continues the normal cadence. A re-entrancy guard keeps the visibility and focus events from running two checks at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A hidden renderer does not run its timers, and macOS can nap the whole process, so the 30m/1h/2h/4h/6h schedule stopped while the app was in the background (verified: a 30 minute timer never fired over a 30 minute background window, while the same build with a 1 minute interval fired normally).
visibilitychange(visible only) andfocus, an overdue check runs immediately and the normal cadence continues from thereVerified with
yarn test:update-check-schedule(due-time helpers) andtest:hot-update; real-device background verification is still pending.