CFtime bug in gridmap #68
Conversation
| for name, obj in xr_objs.items(): | ||
| if "time" in obj.dims: | ||
| if isinstance(obj.get_index("time"), xr.CFTimeIndex): | ||
| conv_obj = obj.convert_calendar("standard", use_cftime=None) |
There was a problem hiding this comment.
I think this function might be a bit dangerous depending on what we are plotting... If we want to see the no leap or 360_day on the time axis, this might be problematic. At least, add a warning to say that you are converting the calendar.
There was a problem hiding this comment.
Agreed. But I see this as a separate issue - check_timeindex is not used in gridmap.
There was a problem hiding this comment.
Ah, ok I see. I had initially modified this function to accept DataArrays and Datasets, and not just dictionaries, to be able to use it in gridmap. This didn't change the logic of how we convert calendars. My latest commit removed it from gridmap.
I'll add a warning for now, and create a separate issue (#72), as I need to look into why I was converting the calendar in the first place.
Co-authored-by: juliettelavoie <[email protected]>
@juliettelavoie can you check if this fix works, or send me a path to a similar file?