Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maximum spacing estimation method to stats.fit #2078

Closed
2 tasks done
SarahG-579462 opened this issue Feb 14, 2025 · 0 comments · Fixed by #2077
Closed
2 tasks done

Add Maximum spacing estimation method to stats.fit #2078

SarahG-579462 opened this issue Feb 14, 2025 · 0 comments · Fixed by #2077
Labels
enhancement New feature or request

Comments

@SarahG-579462
Copy link
Contributor

Addressing a Problem?

Per "A comparative analysis of L-moments, maximum likelihood, and maximum product of spacing methods for the four-parameter kappa distribution in extreme value analysis":

However, a relatively newer, uncommon but effective estimation method exists, namely the maximum product of spacing (MPS). It is a useful method for estimating the parameters of a distribution especially when dealing with small samples. The results of Wong and Li21and Soukissian and Tsalis22 showed that the method of MPS exhibits more stability relative to maximum likelihood and probability-weighted moments (PWM) for the Generalized Extreme Value Distribution. Asquith et al.23 demonstrated a close similarity between the quantile estimates derived from MPS and L-moments in the context of PE3 distribution. Another study by Khan et al.24 illustrated similar findings, indicating that for the intermediate size of samples, the MPS method has better reliability in comparison to L-moments.

In scipy, this method is called MSE, and is available in scipy.stats.fit, but not in scipy.stats.rv_continous.fit (and other dist objects)

Potential Solution

Add MSE / MPS to xclim.indices.stats.fit, using the scipy fit function.

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to contribute this feature.

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant