-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xclim.indices.stats.fit method: MSE (maximum product of spacings) #2077
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I suggest adding a test, atleast to detect if scipy
changes the signature.
I can't find a good explanation on the differences between rv_continuous.fit
and stats.fit
... It seems like the former might use analytical solutions while the latter never will. But it seems confusing to me! And stats.fit
is not mentioned in scipy's "User guide".
Co-authored-by: Pascal Bourgault <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
dist
object.Does this PR introduce a breaking change?
Other information: