Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FutureWarning for sdba migration to xsdba #2073

Merged
merged 10 commits into from
Feb 18, 2025
Merged

FutureWarning for sdba migration to xsdba #2073

merged 10 commits into from
Feb 18, 2025

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Feb 11, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adds a FutureWarning emitted on import of xclim.sdba
  • Adds Warning messages to the API docs page and autogenerated documentation.
  • Adds a workflow that posts a warning message on Pull Requests that modify the xclim.sdba module. Without approval, merging is explicitly blocked.

Does this PR introduce a breaking change?

Yes. xclim.sdba is now officially in the process of being deprecated.

Other information:

https://github.com/Ouranosinc/xsdba

@Zeitsperre Zeitsperre requested a review from a team February 11, 2025 22:07
@Zeitsperre Zeitsperre self-assigned this Feb 11, 2025
@github-actions github-actions bot added sdba Issues concerning the sdba submodule. CI Automation and Contiunous Integration docs Improvements to documenation labels Feb 11, 2025
@Zeitsperre Zeitsperre requested a review from a team February 13, 2025 17:48
@Zeitsperre Zeitsperre added the priority Immediate priority label Feb 17, 2025
@Zeitsperre Zeitsperre added this to the v0.55.0 milestone Feb 17, 2025
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

Do we want to lay out a plan for deprecation right now ? Like what I suggested in the slack:

0.55 : FutureWarning
0.56 :  Switch xclim.sdba with xsdba (xsdba as opt dep of xclim), DeprecationWarning
0.57 : Full split, remove xclim.sdba

This suggested plan was only an idea, maybe that's too fast ?

@github-actions github-actions bot added the approved Approved for additional tests label Feb 17, 2025
@Zeitsperre
Copy link
Collaborator Author

Do we want to lay out a plan for deprecation right now ? Like what I suggested in the slack:

0.55 : FutureWarning
0.56 :  Switch xclim.sdba with xsdba (xsdba as opt dep of xclim), DeprecationWarning
0.57 : Full split, remove xclim.sdba

This suggested plan was only an idea, maybe that's too fast ?

I think you're right that it's a bit fast. What if we were to transition over a longer period? i.e.

0.55 : FutureWarning
0.56 : Switch xclim.sdba with xsdba (xsdba as opt dep of xclim), DeprecationWarning
0.59 / Summer 2025 : Full split, remove xclim.sdba

This would give users a few months to adapt to the changes while the integration kinks can be worked out on the xscen side. Thoughts?

@aulemahal
Copy link
Collaborator

A whole 4 versions with a warning emitted each time you import a package seems long to me... Another solution could be:

0.56 (March)       : FutureWarning
0.57 (April / May) : Switch xclim.sdba with xsdba (xsdba as opt dep of xclim), DeprecationWarning
0.58 (Summer)      : Full split, remove xclim.sdba

I.e. wait for the xscen test to be successful before launching the process. I also included in this estimate a guess that xclim's development won't be 1 release/month in the next half-year 😅

@Zeitsperre
Copy link
Collaborator Author

We can hold off if we think that's best. @tlogan2000, what say you?

@tlogan2000
Copy link
Collaborator

We can hold off if we think that's best. @tlogan2000, what say you?

ok with me

@Zeitsperre
Copy link
Collaborator Author

OK, let's push this to v0.56. I'll merge this right after the next release.

@Zeitsperre Zeitsperre modified the milestones: v0.55.0, v0.56.0 Feb 17, 2025
@Zeitsperre Zeitsperre removed the priority Immediate priority label Feb 17, 2025
@Zeitsperre Zeitsperre merged commit c3cb74d into main Feb 18, 2025
22 checks passed
@Zeitsperre Zeitsperre deleted the deprecate-sdba branch February 18, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration docs Improvements to documenation sdba Issues concerning the sdba submodule.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants