-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FutureWarning for sdba migration to xsdba
#2073
Conversation
… changes to xclim.sdba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed!
Do we want to lay out a plan for deprecation right now ? Like what I suggested in the slack:
0.55 : FutureWarning
0.56 : Switch xclim.sdba with xsdba (xsdba as opt dep of xclim), DeprecationWarning
0.57 : Full split, remove xclim.sdba
This suggested plan was only an idea, maybe that's too fast ?
I think you're right that it's a bit fast. What if we were to transition over a longer period? i.e.
This would give users a few months to adapt to the changes while the integration kinks can be worked out on the |
A whole 4 versions with a warning emitted each time you import a package seems long to me... Another solution could be:
I.e. wait for the xscen test to be successful before launching the process. I also included in this estimate a guess that xclim's development won't be 1 release/month in the next half-year 😅 |
We can hold off if we think that's best. @tlogan2000, what say you? |
ok with me |
OK, let's push this to v0.56. I'll merge this right after the next release. |
Pull Request Checklist:
xlim.sdba
intoxsdba
#2074number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
FutureWarning
emitted on import ofxclim.sdba
Warning
messages to the API docs page and autogenerated documentation.xclim.sdba
module. Without approval, merging is explicitly blocked.Does this PR introduce a breaking change?
Yes.
xclim.sdba
is now officially in the process of being deprecated.Other information:
https://github.com/Ouranosinc/xsdba