Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for custom missing methods #2076

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

I had completely forgotten that we had a section explaining how to create custom missing methods! This updates the notebook with the new way of doing things, but also adds a warning because this is still experimental.

Does this PR introduce a breaking change?

No.

Other information:

Sry for the broken builds!

@aulemahal aulemahal requested a review from Zeitsperre February 12, 2025 20:13
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the docs Improvements to documenation label Feb 12, 2025
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@github-actions github-actions bot added the approved Approved for additional tests label Feb 12, 2025
@Zeitsperre Zeitsperre merged commit a912e8a into main Feb 12, 2025
37 checks passed
@Zeitsperre Zeitsperre deleted the fix-custom-missing-doc branch February 12, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests docs Improvements to documenation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants