Fix two indicator signature issues - clean up changelog #2080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
phase
parameter of precip_accumulation is not included in the indicator docstring but discussed in the docstring #1763 and fixesxclim.atmos.growing_season_end
gives operationValueError
and returns nan values #2056.number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
op
ingrowing_season_end
.thresh
fromprecip_accumulation
's signature.rv_continuous
.Does this PR introduce a breaking change?
Yes and no, the default argument of an indicator was changed. But the previous one was raising an error.
Other information: