Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two indicator signature issues - clean up changelog #2080

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

What kind of change does this PR introduce?

  • Fix overriden default value of op in growing_season_end.
  • Remove thresh from precip_accumulation's signature.
  • Clean up the changelog:
    • In "New indicators", point to indicators, not indices
    • Move mention of CO2 tracking to internal changes.
    • Move "Bug fixes" above "Internal changes"
    • Add precision to the mention of rv_continuous.

Does this PR introduce a breaking change?

Yes and no, the default argument of an indicator was changed. But the previous one was raising an error.

Other information:

@aulemahal aulemahal requested a review from Zeitsperre February 17, 2025 16:48
@github-actions github-actions bot added the indicators Climate indices and indicators label Feb 17, 2025
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changelog cleanup!

@github-actions github-actions bot added the approved Approved for additional tests label Feb 17, 2025
Co-authored-by: Trevor James Smith <[email protected]>
@Zeitsperre Zeitsperre merged commit 389bd6c into main Feb 17, 2025
22 checks passed
@Zeitsperre Zeitsperre deleted the fix-2056-1763 branch February 17, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests indicators Climate indices and indicators
Projects
None yet
2 participants