-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Python3.10, drop Black/Isort/NBQA #2082
Conversation
…e-commit-hooks, remove nbqa hook
Note It appears that this Pull Request modifies the On inspection, the No further action is required. |
This is waiting on the release of the new |
@aulemahal This is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The future is now.
Pull Request Checklist:
ruff
#1805number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
scipy
SPEC-0 suggestionsblack
,isort
, andnbqa
formatting toolsDoes this PR introduce a breaking change?
Yes. Python3.10 is no longer supported. Several core dependencies have also been updated (
scikit-learn
,numpy
,numba
,scipy
,pyarrow
)Other information:
numpy
has suggested dropping support of v1.24 (https://numpy.org/neps/nep-0029-deprecation_policy.html). If we wish to, we can pinnumpy
andnumba
higher.The linting dependencies are all made redundant with
ruff
.blackdoc
is still present, asruff
does not adjust code blocks inMarkdown
orRestructuredText
.pytest-flake8-rst-docstrings
provides some very specific checks that have not yet been reproduced inruff
.docutils
(which would need to be translated intorust
; Not happening soon.)