Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python3.10, drop Black/Isort/NBQA #2082

Merged
merged 17 commits into from
Feb 21, 2025
Merged

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Feb 18, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Drops support for Python3.10
  • Updates several dependencies according to scipy SPEC-0 suggestions
  • Drops black, isort, and nbqa formatting tools

Does this PR introduce a breaking change?

Yes. Python3.10 is no longer supported. Several core dependencies have also been updated (scikit-learn, numpy, numba, scipy, pyarrow)

Other information:

numpy has suggested dropping support of v1.24 (https://numpy.org/neps/nep-0029-deprecation_policy.html). If we wish to, we can pin numpy and numba higher.

The linting dependencies are all made redundant with ruff.

  • blackdoc is still present, as ruff does not adjust code blocks in Markdown or RestructuredText.
  • pytest-flake8-rst-docstrings provides some very specific checks that have not yet been reproduced in ruff.
    • Reproducing this functionality is particularly complex since it relies on docutils (which would need to be translated into rust; Not happening soon.)

@Zeitsperre Zeitsperre added the standards / conventions Suggestions on ways forward label Feb 18, 2025
@Zeitsperre Zeitsperre requested a review from aulemahal February 18, 2025 19:13
@Zeitsperre Zeitsperre self-assigned this Feb 18, 2025
@github-actions github-actions bot added CI Automation and Contiunous Integration docs Improvements to documenation labels Feb 18, 2025
Copy link

Note

It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2025.1.8).

No further action is required.

@Zeitsperre
Copy link
Collaborator Author

This is waiting on the release of the new sphinx-autodoc-typehints on conda-forge.

@Zeitsperre
Copy link
Collaborator Author

@aulemahal This is ready for review!

Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The future is now.

@github-actions github-actions bot added the approved Approved for additional tests label Feb 21, 2025
@Zeitsperre Zeitsperre merged commit 6a58815 into main Feb 21, 2025
23 checks passed
@Zeitsperre Zeitsperre deleted the deprecate-python310 branch February 21, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration docs Improvements to documenation standards / conventions Suggestions on ways forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace more lint tooling with ruff
2 participants