Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with xr.core.ops renamed in versions of xarray>=2025.3.0 #2114

Merged
merged 7 commits into from
Mar 24, 2025

Conversation

jensdebruijn
Copy link
Contributor

@jensdebruijn jensdebruijn commented Mar 20, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • This PR fixes an issue with an operation not being available in xarray versions later than 2025.3.0

Does this PR introduce a breaking change?

No breaking changes

Other information:

Copy link

github-actions bot commented Mar 20, 2025

Welcome, new contributor!

It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the AUTHORS.rst and .zenodo.json:

  • The relevant author information has been added to AUTHORS.rst and .zenodo.json

Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨

@github-actions github-actions bot added the docs Improvements to documenation label Mar 20, 2025
Copy link
Contributor

@coxipi coxipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

There is also a zenodo.json where you can add your information

Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ach I can't believe we didn't do that earlier. Thanks a lot!

@Zeitsperre
Copy link
Collaborator

Looks like the latest ruff is catching some new errors. Updating in another branch.

@Zeitsperre Zeitsperre changed the base branch from main to revert-star-annotation March 21, 2025 16:51
@Zeitsperre
Copy link
Collaborator

@jensdebruijn I needed to change the branch to one that contained a linting fix to get this to build properly. I hope that's alright.

Bedankt voor de code "changes" en goededag!

@Zeitsperre Zeitsperre merged commit e003c46 into Ouranosinc:revert-star-annotation Mar 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements to documenation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'xarray.core' has no attribute 'ops' in xarray 2025.03.0
4 participants